Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 fix: Azure Assistants, use deploymentName as Run Model #2736

Merged
merged 1 commit into from
May 16, 2024

Conversation

danny-avila
Copy link
Owner

Summary

Noticed while implementing Assistants V2 there was an issue on the main branch with azure assistants not using the actual deployment for the model field, as required by Azure OpenAI.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@danny-avila danny-avila merged commit 8a7f36f into main May 16, 2024
2 checks passed
@danny-avila danny-avila deleted the azure-asst-fix branch May 16, 2024 03:34
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant